Fix duplicate operation ids in overloads that are composable.#645
Merged
andrueastman merged 2 commits intosupport/v1from Jan 22, 2025
Merged
Fix duplicate operation ids in overloads that are composable.#645andrueastman merged 2 commits intosupport/v1from
andrueastman merged 2 commits intosupport/v1from
Conversation
|
andrueastman
requested review from
baywet,
danielmbaluka,
darrelmiller,
gavinbarron,
irvinesunday,
millicentachieng and
xuzhg
as code owners
baywet
approved these changes
Jan 22, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for the fix, can you please also reflect the changes in v2?
Member
|
Thank you for double checking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #642
Regression introduced due duplicate operation ids. The change doesn't seem like it was replicated in the v2 branch merge at #641. So no need of a second PR.